Do not fail a lead conversion when SMTP is not configured - #4
Merged
Conversation
SetConfigEmail() throws when the company has no mail host set. In convertToDeal() both sends sit after the client is created and before the deal is made, so an unconfigured mail server returned a 500 and left the conversion half done: client created, deal never made. Both sends are now guarded and the reason logged. The conversion completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetConfigEmail()throws when the company has no mail host configured:In
convertToDeal()both the verification email and the welcome email are sent after the client is created and before the deal is made, and neither was guarded. A company without SMTP got a 500 and a half-finished conversion: the client existed, the deal never did.Both sends are now wrapped and the reason logged. The conversion completes and the client is still created.
Same root cause as the core app's user-creation 500, fixed there in the same batch. Reproduced locally by pointing mail at a host that fails with verification on.