Remove em dashes from docs - #2
Merged
Merged
Conversation
Mostly punctuation in prose. Two changes are not: The reference generator used an em dash as the placeholder for "no methods", so it kept regenerating them into the package pages. It now says "none", which reads better anyway. The last four came from the real-estate and restaurant composer.json descriptions, fixed in those packages. The reference pages here are regenerated from that metadata rather than edited by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly punctuation. Two are not:
The reference generator used an em dash as its placeholder for "no methods" (
${info.methods.join(", ") || "—"}), so hand-editing the generated pages would have been undone by the nextnpm run gen:reference. Changed the placeholder tononeand regenerated.Four lines came from package metadata, not from this repo: the
real-estateandrestaurantcomposer.jsondescriptions. Fixed in those package repos; the pages here are regenerated from that metadata.Verified:
npm run buildsucceeds, and no em dash remains in the repo.