gpui_macos: restore size-dependent glyph padding - #63469
Open
VladimirKras wants to merge 1 commit into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @VladimirKras on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix clipped left edges when CoreGraphics rasterizes larger glyphs on macOS.
font-kitscales typographic bounds from the base font, but CoreGraphics renders a size-specific font whose ink can extend farther left. The regression became visible after the size-dependent left margin introduced in #47001 was replaced with a uniform one-device-pixel margin in #54886.For example, a bold tabular system-font
0at 48 px and 2× scale lost pixels along its left curve.Solution
Restore the previous size-dependent left margin:
Bounds::extend(Edges).The left margin is the historical total margin; the uniform one-pixel margin is not added to it again.
Add two macOS regression tests:
The additional
objc2-app-kitfeature flags are test-only dev-dependencies and do not affect normal debug or production builds.Testing
Tested on macOS with:
cargo test -p gpui_macos --features font-kitcargo clippy -p gpui_macos --features font-kit --all-targets -- -D warningscargo fmt -p gpui_macosThe regression tests cover a bold tabular SF-system
0at 48 px and 2× scale, matching the observed failure.A paired release microbenchmark of the production bounds calculation found no performance regression:
This change only affects the macOS text backend. Other platforms were not tested because their implementations are unchanged.
Self-Review Checklist:
Showcase
All images show the same bold tabular system-font
0at 48 px and 2× scale.The GPUI rendering after the fix and the native AppKit reference are pixel-identical.
Release Notes: