Skip to content

workspace: Fix panel toggle visibility checks - #63458

Open
mateioprea wants to merge 3 commits into
zed-industries:mainfrom
mateioprea:fix/pannel-toggle-fixes
Open

workspace: Fix panel toggle visibility checks#63458
mateioprea wants to merge 3 commits into
zed-industries:mainfrom
mateioprea:fix/pannel-toggle-fixes

Conversation

@mateioprea

Copy link
Copy Markdown
Contributor

Objective

We're fixing toggle behavior for different panels and consolidate that into one simple workspace toggle_panel function. This PR is based on the issue raised in #63243. I saw that all of the panels behaved the same.

Solution

The solution was to consolidate a the check behind a simple workspace function: toggle_panel that check if a specific panel is visible and decides what to do next: if its visible it will simply close it. otherwise it will follow the open & focus branch.
I also added a function for checking if a panel is open.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Showcase

This section is optional. If this PR does not include a visual change or does not add a new user-facing feature, you can delete this section.

  • Help others understand the result of this PR by showcasing your awesome work!
  • If this PR includes a visual change, consider adding a screenshot, GIF, or video
    • A before/after comparison is very useful for changes to existing features!

While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:

Click to view showcase

My super cool demos here


Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Aug 30, 2026
@mateioprea mateioprea changed the title Fix/pannel toggle fixes workspace: Fix panel toggle visibility checks Aug 30, 2026
@ChristopherBiscardi ChristopherBiscardi added the area:workspace Feedback for workspace management, layout, interactions, etc label Aug 31, 2026
@ChristopherBiscardi ChristopherBiscardi self-assigned this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:workspace Feedback for workspace management, layout, interactions, etc cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants