Pin cocoa-foundation to avoid deprecation warnings - #63408
Open
Vanuan wants to merge 2 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Prevent build failures on macOS targets caused by deprecation warnings in
cocoa-foundation v0.2.1when compiling with-D warnings/#![deny(warnings)].When Cargo resolves dependencies for crates depending on
cocoa(such asgpui_apple),cocoa v0.26.0pulls the latest compatible patch version ofcocoa-foundation(0.2.1). Because upstream markedcocoa-foundation 0.2.1as deprecated in favor ofobjc2, compiler deprecation warnings are emitted, causing hard build failures in strict warning environments.Solution
cocoa-foundationto exact version=0.2.0in the workspace manifest (Cargo.toml) and referenced it where necessary to constrain transitive resolution.Testing
cargo update -p gpui_appledoesn't updatecocoa-foundationfrom0.2.0to0.2.1.cargo tree -i cocoa-foundation@0.2.0that all transitive instances ofcocoa-foundationresolve strictly to0.2.0.Self-Review Checklist:
Release Notes: