Add Duso language support#5174
Conversation
davebalmer
commented
Mar 10, 2026
davebalmer
commented
- LSP
- syntax highlighting
- LSP - syntax highlighting
|
We require contributors to sign our Contributor License Agreement, and we don't have @davebalmer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @davebalmer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @davebalmer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Please
- use the
Worktree::whichAPI to look for the Duso LSP binary and return an error if the binary cannot be found - remove the grammars directory, as this should not be part of the extension here.
|
OK I will address these. Sorry I missed them. thank you! BTW I saw the CLI fail, missing license. Weird my LICENSE file is Apache 2.0 what am I missing? https://github.com/duso-org/duso-zed/blob/main/LICENSE thanks again! |
|
Hopefully the changes work. Please let me know. This is my first time making an extension for Zed 😁 |
|
Hi! Just checking back in. @MrSubidubi Have you had a chance to review my changes? Thanks! |
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Sorry for the delay, fine as-is now. Thanks!
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Ah or maybe not quite. Your extension is missing a license. See https://zed.dev/docs/extensions/developing-extensions#extension-license-requirements for a list of accepted license and more information on this.
MrSubidubi
added
the
missing-license
|
@MrSubidubi Thanks! Weird though. It was in Apache 2.0 but I had cleaned up the formatting a bit for markdown. Maybe the detection requires exact match. I reverted back to the original txt version from Apache org, hopefully it'll pass now. It's in the file LICENSE and the copyright boilerplate was updated in the README.md to exactly what Apache recommends. Let me know if there's something else needs doing. 😊 |
|
I made the detection a bit less prone to alternative formattings recently, but well, maybe was not sufficient here. Otherwise, could you please update the submodule to the commit I should look at? |
|
Sorry, what else needs to be done? I'm a little lost. I thought the holdup was the license, but I replaced it with a fresh Apache 2.0. Am I missing something? 😅 |
|
@MrSubidubi Sorry, which commit in the duso repo should I update the submodule to point at? |
|
Whatever you feel like, latest is just fine but optimally one that includes the license |
2 participants
