ZIP 143, ZIP 243: Note that test vectors are randomly generated.#1287
Draft
nuttycom wants to merge 1 commit into
Draft
ZIP 143, ZIP 243: Note that test vectors are randomly generated.#1287nuttycom wants to merge 1 commit into
nuttycom wants to merge 1 commit into
Conversation
Clarifies (per zcash#356) that the sample transactions used to exercise the sighash algorithm are randomly generated and are not necessarily valid Zcash transactions; their purpose is to verify the transaction digest algorithm rather than to pass full validation. Closes zcash#356. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Clarifies (in the Example sections of both ZIPs) that the sample
transactions used to exercise the sighash algorithm are randomly
generated and are not necessarily valid Zcash transactions; their
purpose is to verify the transaction digest algorithm rather than to
pass full validation. The note added to ZIP 143 mirrors the (now
slightly extended) note that ZIP 243 already carried.
Filed with Claude Code assistance.