player: 99.8196% -> 99.8207% (rev1 .sbss symbol pairing + typed PlayerStatus health clamp) - #44
Open
SirEnkido wants to merge 2 commits into
Open
player: 99.8196% -> 99.8207% (rev1 .sbss symbol pairing + typed PlayerStatus health clamp)#44SirEnkido wants to merge 2 commits into
SirEnkido wants to merge 2 commits into
Conversation
…14% -> 100%, matched_data 100%) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… clamp in seq flag 0x28, pathBearingEyeY operand order) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
config/GSAE01_rev1/symbols.txt: pair four rev1.sbssplaceholder labels with the namesplayer.calready declares (lbl_803DF0B0 -> lbl_803DE430,lbl_803DF0D8 -> lbl_803DE458,lbl_803DF0E4 -> lbl_803DE464,lbl_803DF130 -> lbl_803DE4B0). Addresses unchanged; only the names move so dtk/objdiff can pair the rev1 data with the source symbols. player.sbss92.14% -> 100%,matched_data-> 100%.src/dlls/objects/195_Player/player.c(player_SeqFn, seq flag 0x28): replace the hardcoded*(s8*)(*(int*)(h + 0x35c) + 1)/+0accesses with typedPlayerState->playerStatus->maxHealth/->health(layout already asserted:playerStatusat 0x35C,PlayerStatus { s8 health; s8 maxHealth; ... }), and swap the operand order of thepathBearingEyeY + worldPosYadd. Unit fuzzy 99.8196% -> 99.8207%.Evidence
timeout -k 15 900 ninja all_source progress build/GSAE01_rev1/report.jsonexit 0.build/GSAE01_rev1/report.jsonunitmain/dlls/objects/195_Player/player: fuzzy_match_percent 99.820656, matched_data_percent 100.0 (10168/10168 bytes), all data sections 100%, 212/233 functions matched.gPlayer*symbol inconfig/GSAE01/symbols.txtvsconfig/GSAE01_rev1/symbols.txt; sizes/types identical; rev1 asm (player.s) accesses the four objects at the declared widths (stfsx2,sth,lbz/stb).Notes for review
lbl_/fn_names in source (the fourlbl_803DE4xxnames pre-exist inplayer.candconfig/GSAE01/symbols.txt); nothing fromorig/orbuild/; the dtk.sdata2residue linelbl_803E83C8is not in any commit.player.cis not yet a cleaned TU.Produced by Claude agents following AGENTS.md, operated by @SirEnkido.
🤖 Generated with Claude Code