Skip to content

engine/0: 92.29% -> 99.46% (rev1 symbols + gameUiDrawNpcDialogueText helper; v1.00 byte-identical) - #42

Open
SirEnkido wants to merge 2 commits into
zcanann:mainfrom
SirEnkido:agent/engine0
Open

engine/0: 92.29% -> 99.46% (rev1 symbols + gameUiDrawNpcDialogueText helper; v1.00 byte-identical)#42
SirEnkido wants to merge 2 commits into
zcanann:mainfrom
SirEnkido:agent/engine0

Conversation

@SirEnkido

Copy link
Copy Markdown

What changed

Two commits for main/dlls/engine/0/0 (game UI / HUD):

  1. config/GSAE01_rev1/symbols.txt: renamed 20 stale fn_<addr> entries to the canonical names already used by the v1.00 config and source (each checked against EN size/order; asm bodies of the small setters/getters match the C). This alone took the rev1 unit from 81 to 99 matched functions.
  2. src/dlls/engine/0/0.c: added gameUiDrawNpcDialogueText, a 0xFC-byte helper that the PAL / EN-rev1 builds factored out of GameUI_hudDraw (exact match). It is compiled only for non-EN/JP versions via #if defined(VERSION_GSAE01) || defined(VERSION_GSAJ01) / #else; GameUI_hudDraw keeps the original inlined code for GSAE01/GSAJ01.

Evidence

  • main/dlls/engine/0/0 on GSAE01_rev1: 92.29% → 99.46%, matched functions 81 → 101 of 119
  • The v1.00 object is byte-identical: 0.c was recompiled for GSAE01 from origin/main and from HEAD with identical cflags — no difference. The active target is unaffected.
  • ninja all_source progress build/GSAE01_rev1/report.json exits 0; independently re-audited

Notes for review

  • This introduces a version-conditional in game source under src/dlls. configure.py already emits -DVERSION_<id> and regional configs compile every unit, so the mechanism is sanctioned — but if you prefer a different style (e.g. a BUILD_VERSION comparison, or keeping revision-specific helpers elsewhere), say the word and I'll restructure. Fallback: drop commit 2 and keep the symbols-only commit 1 (92.29% → 98.80%).
  • pauseMenuDraw remains the weakest function in the rev1 unit at 94.6% (rev1 0x122C vs EN 0x11D4); the fn_801265B0 → pauseMenuDraw rename is justified by call-site/order evidence but the body divergence is not addressed here.

Produced by Claude agents following AGENTS.md, operated by @SirEnkido.

🤖 Generated with Claude Code

SirEnkido and others added 2 commits August 15, 2026 18:00
… config, 81->99 matched)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…PAL/rev1 factored NPC dialogue text drawing out of GameUI_hudDraw; both now match)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant