engine/0: 92.29% -> 99.46% (rev1 symbols + gameUiDrawNpcDialogueText helper; v1.00 byte-identical) - #42
Open
SirEnkido wants to merge 2 commits into
Open
engine/0: 92.29% -> 99.46% (rev1 symbols + gameUiDrawNpcDialogueText helper; v1.00 byte-identical)#42SirEnkido wants to merge 2 commits into
SirEnkido wants to merge 2 commits into
Conversation
… config, 81->99 matched) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…PAL/rev1 factored NPC dialogue text drawing out of GameUI_hudDraw; both now match) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two commits for
main/dlls/engine/0/0(game UI / HUD):config/GSAE01_rev1/symbols.txt: renamed 20 stalefn_<addr>entries to the canonical names already used by the v1.00 config and source (each checked against EN size/order; asm bodies of the small setters/getters match the C). This alone took the rev1 unit from 81 to 99 matched functions.src/dlls/engine/0/0.c: addedgameUiDrawNpcDialogueText, a 0xFC-byte helper that the PAL / EN-rev1 builds factored out ofGameUI_hudDraw(exact match). It is compiled only for non-EN/JP versions via#if defined(VERSION_GSAE01) || defined(VERSION_GSAJ01)/#else;GameUI_hudDrawkeeps the original inlined code for GSAE01/GSAJ01.Evidence
main/dlls/engine/0/0on GSAE01_rev1: 92.29% → 99.46%, matched functions 81 → 101 of 1190.cwas recompiled for GSAE01 fromorigin/mainand fromHEADwith identical cflags — no difference. The active target is unaffected.ninja all_source progress build/GSAE01_rev1/report.jsonexits 0; independently re-auditedNotes for review
src/dlls.configure.pyalready emits-DVERSION_<id>and regional configs compile every unit, so the mechanism is sanctioned — but if you prefer a different style (e.g. aBUILD_VERSIONcomparison, or keeping revision-specific helpers elsewhere), say the word and I'll restructure. Fallback: drop commit 2 and keep the symbols-only commit 1 (92.29% → 98.80%).pauseMenuDrawremains the weakest function in the rev1 unit at 94.6% (rev1 0x122C vs EN 0x11D4); thefn_801265B0 → pauseMenuDrawrename is justified by call-site/order evidence but the body divergence is not addressed here.Produced by Claude agents following
AGENTS.md, operated by @SirEnkido.🤖 Generated with Claude Code