object: 94.09% -> 99.79% (rev1 symbols: name 9 stale fn_ stubs, fix Obj_UnregisterEffectBox split) - #41
Open
SirEnkido wants to merge 3 commits into
Open
object: 94.09% -> 99.79% (rev1 symbols: name 9 stale fn_ stubs, fix Obj_UnregisterEffectBox split)#41SirEnkido wants to merge 3 commits into
SirEnkido wants to merge 3 commits into
Conversation
… fn_ stubs from the GSAE01 config; Obj_UnregisterEffectBox is one 0x108 function, not 0x104 + a stray blr) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ith their canonical GSAE01 names (score-neutral; only the rev1-only 'FREED OBJECT %s' string keeps its lbl_) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…(build-time artifact, not part of the object.c rename) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
config/GSAE01_rev1/symbols.txtonly — no C source changes.The GSAE01_rev1 symbol projection had left nine
object.cfunctions asfn_<addr>stubs, so objdiff could not pair them with the source (which already implements them correctly) and they scored zero. This branch:doNothing_afterRenderObject,doNothing_beforeRenderObject,Obj_ClearModelSlotIndex(stb -1 at 0xac),objIsFrozen(lbz 0xe5 & 1),Obj_UnregisterEffectBox,getTrickyObject/Obj_GetPlayerObject(objGetAllOfType(1)/(0)),Obj_FreeObject(gObjList / gObjPendingDefFreeList body)fn_8002B830(0x104) + a stray 4-byteblrfn_8002B934is one function,Obj_UnregisterEffectBox, size 0x108 — matching the GSAE01 layoutobject.c.datastrings/blocks their GSAE01 names (gObjCameraSetupBlock,sObjSetupObjectLoadingLockedWarning,sObjDebugStrings, …). Only the rev1-only"FREED OBJECT %s"string keeps itslbl_(no v1.00 counterpart).Evidence
main/main/objecton GSAE01_rev1: 94.09% → 99.79%, matched functions 51/61 → 58/60Obj_FreeObject/Obj_GetPlayerObjectetc.; global rev1 progress rose by exactly those 424 bytes / 7 functions with no regressions elsewhereninja all_source progress build/GSAE01_rev1/report.jsonexits 0; independently re-auditedNotes for review
Obj_FreeObjectis 0x270 in rev1 vs 0x250 in v1.00 (rev1 adds anOSReportof the FREED OBJECT string), so the shared C body only fuzzy-matches there (94.9%). Kept as v1.00-shaped C perdocs/version_progress.md.lbl_803E83C8label (every rev1 build re-adds it; not part of the change).Produced by Claude agents following
AGENTS.md, operated by @SirEnkido.🤖 Generated with Claude Code