WIP: Update to 2.0.1#14
Conversation
…e, some typescript fixes
…into feature/overlay
Co-authored-by: SeanEZhou <sezhou@andrew.cmu.edu> Co-authored-by: Rong Kang Chew <chewrongkang@gmail.com>
- Changed method of getting the gamecode (works in game now) - Added patternscanning so you wont need to update the server evrey time
- Fix naming for the findpattern function
|
Oops |
This allows the overlay to properly set transparency under Linux. The overlay still doesn't seem to work though.
|
The overlay should be transparent now, but I'm not sure how to get the rest of the overlay working. |
At least until that memoryjs pull-request gets merged into zbanks' fork.
|
Ok so I guess I don't really know if the overly is broken or not, now that it is transparent. The overlay as designed does not display anything until a game is started. I have verified that the react code does get launched via the web console in dev mode. |
|
For me the overlay does not let me click anything in the game so I am disabling it |
|
maybe its possible to add a CLI flag to disable it? Its possible there are just some window managers this will never work on. Edit: Lets not forget about wayland, I have no clue if it could work on that. |
|
Based on the overlay library's github repo. I'd say Wayland is out of the question although it might work via XWayland. (I'm not familiar with Wayland since I have an Nvidia card.) I'll look into adding a cmdline option to hard disable the overlay since the |
The option will prevent the overlay from attaching to Among Us while also disabling the workarounds that got the overlay's transparency working. This for those who have trouble with CrewLink's overlay since the 'hidden' overlay setting within CrewLink doesn't completely stop the overlay from attaching to Among Us.
|
I just tried it out, the overlay is misaligned but that's the only Issue I found. |
|
I ran into that with bspwm, but the overlay itself doesn't stay on top for me. @Fauli1221 Does it actually display anything for you? Also, messing with the electron-overlay-window demo code I noticed that the |
|
I just tested under Awesome (latest commit from this PR, the kernel Arch Linux with Linux 5.10.8-zen1-1-zen), the overlay is created in another window I can manually align with Among Us, but it also prevents me from clicking anything. |
|
Is detection working properly for anyone? The lack of talk about it is starting to make me wonder. I still can't get it working on Mint 20 with the latest commit. Overlay is honestly the least of my concerns. |
|
@pilot51 I haven't had any issues getting CrewLink to detect the game ever since I got memoryjs's Are you running CrewLink after Among Us has started? |
|
Nevermind, my mistake. I'm using a script that automatically sets ptrace before and after running CrewLink and I forgot to update it from 2.0.0 to 2.0.1. It's working now. |
|
@TheGreatMcPain hey, I see you're another Gentoo 'nerd' 😄 - can we have a chat about CrewLink issues on IRC some time? I am kinda interested to see if we can also port Bettercrewlink over to Linux also. I'm having some epic audio issues, not sure what is going on. Weirdly, it seems like I have a working overlay on KDE/Kubuntu ... (!). Have set up yarn here, but it sucks CPU something silly (possibly also the reason why audio stutters like a b1tch .. |
|
@mjeveritt Sure, but I'm not too familiar with IRC (I only used it to access xbins(dot)org to get OG Xbox homebrew software). I'd imagine getting BetterCrewLink working on Linux shouldn't be too difficult since it doesn't require any extra I did have some "robo" voice issues when used 1.2.1 with some friends before 2.0.0 came out. It seems like it was happening on their end too, so it's not entirely a Linux specific issue. |
There's a webchat for Freenode, or other clients from (he)xchat, irrsi etc. Reason I mention it is a lot of Gentoo dev does also go on there too! My nick is 'kveremitz' over there.
Yeah we tried a couple of different servers, but the problem definitely prevailed. Looking in htop there was a process in /proc/sys/exe or such hogging CPU which doesn't sound right. It definitely seemed like some resource bottleneck. |
|
It's working for me! There was some glitches, but no more than for my Windows-using friends. Thanks for the work you've put into this @TheGreatMcPain and @zbanks |
I've implemented getProcesses in my fork of memoryjs. CrewLink can now be launched before launching Among Us, and should continue to work even if the game restarts.
|
I have recently implemented This means |
added tar.gz build target
|
Had to close, because github won't let me change the pull-request branch. Continued in #18. |
16 participants
It merged cleanly, but I still have to see if it actually runs.