Handle Wine lock violation errors gracefully on Windows - #29
Open
zaniebot wants to merge 1 commit into
Open
Conversation
`std::fs::File::unlock` calls `UnlockFile` twice on Windows to handle the documented exclusive+shared upgrade case, and tolerates `ERROR_NOT_LOCKED` (158) from the second call. Wine's wineserver returns `ERROR_LOCK_VIOLATION` (33) instead in that situation, which std then propagates and we previously surfaced as a misleading "program may be stuck" error on every lock release under Wine. The handle is dropped immediately after `unlock` returns, so any remaining lock is released by the OS regardless. Detect Wine via `uv_windows::is_wine()` and silently swallow `ERROR_LOCK_VIOLATION` on Wine, with a pointer to the upstream Wine bug. See https://bugs.winehq.org/show_bug.cgi?id=59711 https://claude.ai/code/session_01AM9r3MmphRyDZpkFgvHwoh
zaniebot
force-pushed
the
claude/investigate-uv-pr-bVVQM
branch
from
April 30, 2026 20:09
99fa907 to
261e011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change improves error handling in the
LockedFiledrop implementation to gracefully handle a known Wine compatibility issue on Windows. When running under Wine, file unlock operations may fail withERROR_LOCK_VIOLATIONdue to a Wine bug (see https://bugs.winehq.org/show_bug.cgi?id=59711).The fix:
uv_windows::is_wine()ERROR_LOCK_VIOLATION)This prevents spurious error messages when using uv under Wine while maintaining proper error reporting for genuine lock failures.
Test Plan
Existing tests pass. The change is defensive and only affects error logging behavior in the drop handler for a specific edge case (Wine environment with a known Wine bug).
https://claude.ai/code/session_01AM9r3MmphRyDZpkFgvHwoh