Apex demo: inline access-link preview as the payoff#575
Conversation
Replace the home demo's link-out to a static example page with an inline "mini access-link viewer" that reveals as the final beat of the transcript: a centered, theme-inverted, fixed-width browser-framed panel (fake address bar, traffic-light dots, wordmark brand bar) previewing the published artifact, with the report rows fading out to imply a longer page. - Delete the static /a/art_8KQ2WSDIEGO7XR page (no longer linked; it had drifted from the real /al viewer chrome). - Add a "link" transcript line that hands back the URL right before the preview opens, and tune the shell height so the whole "Done -> here's your link -> preview" handoff lands as the final frame with no scroll. - Report rows read as the user's own agent surfacing personalized, one-shot share use cases (incident writeup, research, migration plan, roadmap), sourced from EXAMPLE_REPORT_ROWS; retune EXAMPLE_PROMPT to lead with the memory angle. - Update render tests to the new contract (inline preview present, no /a/ link-out, access-link URL still surfaced); drop the dead gesture test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughRemoves the static artifact HTML/CSS page and the ChangesInline Preview Transcript Flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.0)apps/apex/src/styles/apex.cssFile contains syntax errors that prevent linting: Line 23: Tailwind-specific syntax is disabled.; Line 25: Tailwind-specific syntax is disabled.; Line 26: Tailwind-specific syntax is disabled.; Line 27: Tailwind-specific syntax is disabled.; Line 28: Tailwind-specific syntax is disabled. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
First-pass review (AP-389)
Risk: simple
Decision: approve
Ticket triage
- Intended change: Replace the apex home demo's link-out to a static
/a/art_…page with an inline mini access-link viewer as the final transcript beat; delete the static page; align copy-prompt copy behavior. - Scope match: Yes — diff is confined to
apps/apexand matches AP-389 acceptance criteria (inline preview, no/a/link-out, updated tests, claim-code copy parity on both affordances).
Review findings
Blocking: none
Non-blocking:
docs/ops/apex-landing-todo.mdstill describes the deleted static page underapps/apex/public/a/art_8KQ2WSDIEGO7XR/— worth a quick doc touch in a follow-up so the next agent isn't misled.- Footer button comment in
TranscriptDemo.tsxstill says it copies the "bare EXAMPLE_PROMPT"; behavior now appends claim code viadata-claim-prompt-variant(same as inline prompt). Comment-only drift.
Merge checklist
- Ticket linked and understood: AP-389
- PR scope matches ticket: yes
- Checks green: Validate, Postgres smoke, secret scan, CodeQL all pass
- Tests/docs appropriate: render tests updated for new preview contract; author verified preview deploy
- No blocking findings: yes
- No high-risk areas: marketing-only surface, no auth/billing/infra
- Merge-safe: yes
Why approve
The implementation is coherent: new link + preview transcript kinds, theme-inverted preview chrome with sensible CSS token overrides, static example deletion to prevent drift, and the inline prompt now shares claim-code copy behavior with the footer button. CI is green and the change stays within a low-risk marketing boundary suitable for first-pass automation approval.
Sent by Cursor Automation: First Pass PR Reviewer
|
agent-paste PR preview resources were cleaned up. The shared Preview GitHub Environment is retained for future preview deploys. |
1 participant
Summary
The apex home demo's payoff was a
resultline linking out to a hand-authored static page (/a/art_8KQ2WSDIEGO7XR, "Project handoff") that had drifted from both the live home-page content and the real/alaccess-link viewer chrome — a dead-end the visitor wasn't meant to dwell on. This inlines the payoff so it can't drift again and keeps the visitor in the funnel: the demo now ends in a mini access-link viewer that looks like a real opened browser page.Changes
preview(mini access-link viewer): centered, theme-inverted vs the page, fixed-width, browser-framed (fake address bar + traffic-light dots + wordmark brand bar); report rows fade out at the bottom to imply a longer page.linktranscript line that hands back the URL right before the preview opens; tune the shellmax-hso the whole "Done → here's your link → preview" handoff lands as the final frame with no internal scroll.EXAMPLE_REPORT_ROWS) read as the user's own agent surfacing personalized, one-shot share use cases (incident writeup, research, migration plan, roadmap); retuneEXAMPLE_PROMPTto lead with the memory angle.--claim-codeline, and both fire the funnel attribution./a/art_8KQ2WSDIEGO7XRpage (no longer linked; it 404s now)./a/link-out, access-link URL still surfaced); drop the dead gesture test.Risk: LOW
apps/apexonly (prerendered marketing site) —copy.ts,TranscriptDemo.tsx,apex.css,render.test.tsx, plus deletion of the static example page./a/<id>was demo-only and never in redirects/asset whitelists.Test plan
pnpm --filter @agent-paste/apex test(88 passed),typecheck,lintcleanpnpm verify(261 tests + smoke) andpnpm test:coveragegreenpnpm deploy:preview --app=apex): animated run ends on the inline preview; reduced-motion / no-JS static fallback shows it; old/a/art_8KQ2WSDIEGO7XRreturns 404; both copy affordances copy the same prompt + claim-code textIssue: AP-389
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Style
Chores