refactor(AP-128): import shared routeContractById in api, upload, content

[isuttell]

Summary

Removes three duplicate local contractById helpers and routes all three Workers through the shared routeContractById export from @agent-paste/contracts.

Changes

• api (route-contracts.ts): Re-exports routeContractById as contractById; aliases RouteContractById for existing ContractById type usage.
• upload / content: Replace local lookup implementations with const contractById = routeContractById near module setup (content now gets the same Extract<> narrowing as api/upload).
• test: Expect the shared error message (Unknown route contract: …) for missing ids.

Verification

• pnpm verify
• pnpm test:coverage

Linear Issue: AP-128

  

[linear-code]

AP-128 Import shared routeContractById instead of three local copies

Parent: AP-126. Architecture review finding #4. No hot seam — fully parallel-safe; good first/warm-up ticket.

Outcome

The three Workers resolve a Route Contract by id through the single exported routeContractById from @agent-paste/contracts instead of three slightly-different local copies, so the typed narrowing is consistent across api, upload, and content.

Context docs

• docs/ops/architecture-review-2026-06-02.md (finding feat: wire runCommand into mutation routes #4)
• docs/adr/0072-contract-driven-route-registrar-and-guard.md

Problem

packages/contracts/src/routes/registry.ts:565-571 already exports a typed routeContractById<Id>(id). But each Worker re-implements its own contractById: apps/api/src/route-contracts.ts:9-15, apps/upload/src/index.ts:628-634, apps/content/src/index.ts:382-388. The copies drift — content's loses the Extract<...> narrowing the others have. Pure pass-throughs that fail the deletion test (the behavior already exists in the shared export).

Likely files / packages

• apps/api/src/route-contracts.ts
• apps/upload/src/index.ts
• apps/content/src/index.ts
• packages/contracts/src/routes/registry.ts (import source; no change expected)

In scope

• Delete the three local contractById functions; import routeContractById from @agent-paste/contracts.
• Re-export under the existing local name per app if there are many call sites, to keep the diff small.
• Ensure content gets the same typed narrowing as api/upload.

Out of scope

• Any change to the shared routeContractById signature or the contracts registry structure.

Acceptance criteria

• No local contractById/equivalent route-contract-by-id lookup remains in the three apps.
• All three import the shared function; types still compile with the same (or stronger) narrowing.

Required checks

pnpm verify + pnpm test:coverage green. pnpm typecheck confirms the narrowing.

Security / data / operational invariants

None — pure internal refactor, no behavior change.

Dependencies / blockers

None. Parallel-safe with all other AP-126 slices.

Review in Linear

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1834de9e-1a14-45fb-b2b7-ea08014fb74d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/import-route-contract-by-id-c96e

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

agent-paste PR preview is ready.

API: https://agent-paste-api-pr-180.isaac-a46.workers.dev
Upload: https://agent-paste-upload-pr-180.isaac-a46.workers.dev
Content: https://agent-paste-content-pr-180.isaac-a46.workers.dev
Jobs: https://agent-paste-jobs-pr-180.isaac-a46.workers.dev
Apex: https://agent-paste-apex-pr-180.isaac-a46.workers.dev
Web (login): https://pr-180.preview.agent-paste.sh (first deploy: allow a few minutes for the TLS cert)
Neon branch: https://console.neon.tech/app/projects/still-forest-91029005/branches/br-calm-unit-apd3vvr3

[github-actions]

agent-paste PR preview is ready.

API: https://agent-paste-api-pr-180.isaac-a46.workers.dev
Upload: https://agent-paste-upload-pr-180.isaac-a46.workers.dev
Content: https://agent-paste-content-pr-180.isaac-a46.workers.dev
Jobs: https://agent-paste-jobs-pr-180.isaac-a46.workers.dev
Apex: https://agent-paste-apex-pr-180.isaac-a46.workers.dev
Web (login): https://pr-180.preview.agent-paste.sh (first deploy: allow a few minutes for the TLS cert)
Neon branch: https://console.neon.tech/app/projects/still-forest-91029005/branches/br-calm-unit-apd3vvr3

[github-actions]

agent-paste PR preview resources were cleaned up. The shared Preview GitHub Environment is retained for future preview deploys.