feat(settings): rich per-setting detail panel - #9
Merged
Conversation
Rework the Settings config screen to mirror Pi-hole's web UI, showing a per-setting detail panel with description, type, default, current value, allowed inputs, and modified status — sourced from FTL's /api/config?detailed=true metadata that was previously discarded on flatten. - tree.go: carry FTL metadata through the leaf model (newDetailLeaf) - detail.go: responsive Gloss detail panel (side-by-side / stacked), width- gated so it never overflows narrow terminals, with the description prioritized in the height budget so it survives on narrow/SSH panes - settings.go: split width between table and panel; compose the two - tests: metadata capture, panel contents, narrow-width no-overflow guard Also: dev/prod React loader + .gitignore .claude/.
✅ Deploy Preview for tihole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the Settings Configuration screen so each Pi-hole setting shows a thorough detail panel — description, type, default, current value, allowed inputs, and modified status — matching what Pi-hole's own web UI displays. The metadata was already fetched via
GET /api/config?detailed=truebut discarded during flatten; this carries it through and renders it in a "Gloss"-styled panel.Changes
leafnow carries FTL metadata (description,type,default,allowed,modified);newDetailLeafpopulates it instead of collapsing to justvalue.configSplit) and composes them (renderConfigTree)..claude/.Test plan
go test ./internal/...— all pass (incl. new metadata-capture, panel-contents, and narrow-width no-overflow regression tests)go vetclean, golines ≤80 colsdescription, and confirmed the panel renders it in both side-by-side and stacked layouts