Skip to content

Serialize ACP terminal transitions - #135

Merged
yyjeqhc merged 1 commit into
mainfrom
fix/acp-terminal-transition-race
Aug 24, 2026
Merged

Serialize ACP terminal transitions#135
yyjeqhc merged 1 commit into
mainfrom
fix/acp-terminal-transition-race

Conversation

@yyjeqhc

@yyjeqhc yyjeqhc commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Follow-up to #129, which merged while the final review was in progress.

Summary

  • serialize terminal state commits for each CodingAgentRun
  • preserve first-terminal-wins semantics when pre-prompt cancellation races setup failure
  • keep the in-memory snapshot, durable record, and terminal event consistent
  • add a concurrent regression test covering both possible terminal outcomes

Validation

  • cargo fmt -- --check
  • cargo test 'coding_agent' --all-targets -p webcodex-runner — 31 passed, 1 ignored
  • cargo test --all-targets -p webcodex-runner — 774 passed, 4 ignored (same patch before rebasing onto merged main)
  • cargo test 'coding_agent' --all-targets -p webcodex-core — 5 passed
  • cargo test 'coding_agent' --all-targets -p webcodex — 18 passed

@yyjeqhc
yyjeqhc merged commit 0316aa6 into main Aug 24, 2026
6 checks passed
@yyjeqhc
yyjeqhc deleted the fix/acp-terminal-transition-race branch August 24, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant