plugins: make claude-plugin-reset derive from the settings.json manifest - #59
Draft
yulonglin wants to merge 1 commit into
Draft
plugins: make claude-plugin-reset derive from the settings.json manifest#59yulonglin wants to merge 1 commit into
yulonglin wants to merge 1 commit into
Conversation
Follow-up to #58, which made claude/settings.json the single source of truth but left two contradictory hand-lists behind: - config.sh OFFICIAL_PLUGINS/PLUGIN_MARKETPLACES still listed pruned plugins (plugin-dev, ralph-loop), five plugins not in the manifest at all, and 2 of 6 marketplaces — claude-plugin-reset would have reinstalled what #58 pruned. Both arrays are deleted; the script now derives marketplaces from extraKnownMarketplaces and plugins from enabledPlugins at runtime, installing at user scope. - Restore the per-session symlink cleanup that died with context_auto_apply.sh as a minimal SessionStart hook — without it, duplicate skill-picker entries accumulate between deploys. - deploy.sh: drop the hardcoded plugin count (count-shaped claims drift). - statusline.sh: remove the dead profiles_info variable. - stale-claims.sh: pass the settings path via sys.argv, not interpolation. Claude-Session: https://claude.ai/code/session_01WoJYQoyUNVUn56h87MHDQ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #58 — fixes the review findings so the manifest is genuinely the single source of truth.
Changes
claude-plugin-resetnow derives from the manifest.config.sh's hand-maintainedOFFICIAL_PLUGINS/PLUGIN_MARKETPLACESarrays contradicted plugins: replace enable-first profiles with a native all-true manifest #58: they still listed the prunedplugin-devandralph-loop, five plugins not in the manifest at all (code-review,feature-dev,pr-review-toolkit,Notion,vercel), and only 2 of 6 marketplaces — running the reset script would have reinstalled what plugins: replace enable-first profiles with a native all-true manifest #58 pruned. Both arrays are deleted; the script readsextraKnownMarketplacesandenabledPluginsfromclaude/settings.jsonat runtime and installs at--scope user(which also serves plugins: replace enable-first profiles with a native all-true manifest #58's reinstall-at-user-scope follow-up).clean_plugin_symlinks_session.sh). The deletedcontext_auto_apply.shwas also the thing runningclean_plugin_symlinks.shevery session; without it, duplicate skill-picker entries accumulate until the next deploy.deploy.sh: dropped the hardcoded "24" plugin count.statusline.sh: removed the deadprofiles_infovariable and its printf slot.stale-claims.sh: settings path now passed viasys.argvinstead of string interpolation.Verification
claude-plugin-reset --dry-runderives exactly the 6 marketplaces and 24 manifest plugins fromclaude/settings.jsonshellcheckclean on changed scripts;bash -n/zsh -npassstatusLine/hooks/permissionsgate passes; new hook registered in SessionStarthttps://claude.ai/code/session_01WoJYQoyUNVUn56h87MHDQ7