Skip to content

fix(deploy): guard associative-array lookup so extension sync can't abort deploy.sh #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yulonglin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(deploy): guard associative-array lookup so extension sync can't abort deploy.sh #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/shared/helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,9 @@ install_editor_extensions() {
typeset -a to_remove
for ext in "${installed[@]}"; do
[[ -z "$ext" ]] && continue
if [[ -z "${wanted_map[${ext:l}]}" ]]; then
# `:-` is required: under `set -u`, reading a missing associative-array key
# is a fatal zsh error (kills the whole script, not catchable with `||`).
if [[ -z "${wanted_map[${ext:l}]:-}" ]]; then
to_remove+=("$ext")
fi
done
Expand Down