Allow removing stale custom models from picker - #471
Conversation
|
Thanks, this reads like a finished change. A stale persisted custom model should be removable from the picker without touching files on disk, and the rules you list (official, installed and currently selected models stay put) match how the picker is meant to work. If you have the branch, open a pull request against main and we will review it for the next release. The model picker overlay changed in 2.11.2, so rebase on the tag once it is out. |
7f51f76 to
3d6a436
Compare
|
Rebased #471 onto v2.11.2 and re-tested the picker behavior. The stale custom model can still be removed as expected, with the confirmation flow working correctly. |
|
Reviewed the rebased branch (3d6a436) on top of v2.11.2 and the work for the next release: it merges clean, and the app suite passes with it (897 tests, 0 failures), including the eight tests you added and the localization table checks. The four strings the dialog and the context menu use already exist in every language table. The rule (persisted custom, not installed, not selected) and the files-untouched guarantee are exactly right. It is queued for the next release and will be merged under your authorship with it. Thank you for the rebase and the retest. |
Summary
removeCustomModel(id:)configuration API.Removal eligibility
Testing
Remove from pickervia the row context menu and requires confirmation before removal.git diff --checkpasses.