feat(app): remove downloaded models safely - #377
Open
PhilipJohnBasile wants to merge 2 commits into
Open
Conversation
youssofal
force-pushed
the
main
branch
2 times, most recently
from
September 1, 2026 08:07
2382dfd to
8bc4d88
Compare
Signed-off-by: Philip John Basile <PBasile@Basilecom.com>
PhilipJohnBasile
force-pushed
the
codex/issue-374-remove-model
branch
from
September 1, 2026 13:11
0dd69ac to
7a997c8
Compare
Owner
|
Thanks. The safety boundaries are the right ones: only managed cache children, the selected model and active transfers protected, symlinks unlinked without following them. It overlaps the model picker work in flight for the next release, so it will be rebased and landed under your name once that settles. Not in 2.11.2. |
Contributor
Author
|
@youssofal Understood. I am leaving this scoped to safe removal and holding further picker changes until the in-flight picker work settles. The managed-cache, active-model/transfer, and symlink boundaries remain unchanged. The PR stays available for review and your credited integration; I have not introduced another picker implementation or treated the release hold as merge approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
The desktop model picker now offers a confirmed Remove action for installed models. Removal delegates to the existing
mtplx removeJSON contract, then refreshes the picker and model-update state.Safety boundaries:
The CLI removal command is now included in the README quick reference.
Validation:
swift build, Ruff, andgit diff --check: passed@youssofal, please review.