Pinned fastapi version#76
Open
dcerisano wants to merge 1 commit into
Open
Conversation
Author
|
Is this PR going to be merged? If it will be closed without merge a reason should be given. Assuming merge master is on vacation. |
49de835 to
76bb5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes in
fastapi 0.100.0broke EasyLM gradio webapp.App server could not validate JSON, returned error code 422 on POST from client (see error below).
As per fastapi guidance, version should be pinned to prevent this in the future. Pinning back to previous version
fastapi 0.99.1resolves the issue for now, next version release should fix it. (Possible that other packages for EasyLM should be baselined as well).Tested with:
XLA_PYTHON_CLIENT_ALLOCATOR=platform