fix: restore --all-features MSRV coverage via yoagent-state 0.4.2#70
Merged
Conversation
yoagent-state 0.4.2 makes its declared 1.85 MSRV true (let-chain removed upstream in yologdev/yoagent-state#1), so the gasp feature can be MSRV- checked again. Floor bumped to 0.4.2 so a 1.86 toolchain can never resolve the broken 0.4.1. The stale docs caveat is removed. Downstream verified against 0.4.2 before this change: yoagent's 392 tests, yoyo-evolve's gasp-emit (compiles), yyds-harness (0.2.x range, unaffected). This PR's own MSRV job is the final verdict for the 1.86 + --all-features combination. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the loop on the #68 MSRV carve-out. Upstream yoagent-state#1 removed the let-chain that made its declared 1.85 MSRV untrue; 0.4.2 is on crates.io. This PR:
0.4.2(so a 1.86 toolchain can never resolve the broken 0.4.1)cargo check --all-featureson the MSRV (1.86) job — thegaspfeature is MSRV-covered againDownstream verification (done before the upstream release)
tools/gasp-emitvs patched crateyoagent-state = "0.2.0")The verdict is this PR's own CI
Declared MSRVs can lie (that's how we got here) — the MSRV job on this PR is the real test of 1.86 +
--all-features. If it's red, we revert the job line and keep the carve-out; nothing shipped changes either way. Known-safe residual:wasip2(1.87) remains in the resolve but is wasm-only and never built on the CI target (same as since Phase A).🤖 Generated with Claude Code