Make other users' repeating flash intensity consistent with the player's - #68
Merged
Desdaemon merged 1 commit intoJul 29, 2025
Conversation
Looks like the flash is a little bit stronger when Flash is called after Game_Character::Update for the given other player. Spriteset_Map::Update runs after Game_Multiplayer::Update (which calls the individual Update methods of other players) so the call had to be moved to the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the flash is a little bit stronger when
Flashis called afterGame_Character::Updatefor the given other player.Spriteset_Map::Updateruns afterGame_Multiplayer::Update(which calls the individualUpdatemethods of other players) so the call had to be moved to the latter.master