Remove proto_version. - #152
Closed
ltratt wants to merge 1 commit into
Closed
Conversation
This dates from a time when we were seeing random crashes in yklua and I reached for this as a hack: the crashes went away, but I think that was not because `proto_version` was the right fix. Indeed, I'm now fairly confident that `proto_version` is by unnecessary: by definition, if we create a new `Proto` we get a new `YkLocation` so `proto_version` can't do anything. This does lead to a small speedup across several Lua benchmarks.
ltratt
enabled auto-merge
July 21, 2026 15:26
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dates from a time when we were seeing random crashes in yklua and I reached for this as a hack: the crashes went away, but I think that was not because
proto_versionwas the right fix. Indeed, I'm now fairly confident thatproto_versionis by unnecessary: by definition, if we create a newProtowe get a newYkLocationsoproto_versioncan't do anything. This does lead to a small speedup across several Lua benchmarks.