chore: update composer.json to remove unused plugin.#94
Conversation
…tion files and update `composer.json` to remove unused plugin.
|
Warning Review limit reached
More reviews will be available in 53 minutes and 29 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughExplicit ChangesTest fixture closures, Rector config, and Composer plugin cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 108 108
===========================================
Files 2 2
Lines 230 230
===========================================
Hits 230 230 ☔ View full report in Codecov by Harness. |
terabytesoftw
changed the title
composer.json to remove unused plugin.composer.json to remove unused plugin.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 18: The changelog entry on line 18 contains a reference to updating
composer.json to remove an unused plugin, but this change is not actually
present in the current review. Remove the portion of the changelog entry that
mentions the composer.json modification and the yii2-extensions/scaffold plugin
removal. Keep only the accurate description about adding return type
declarations for closures in test configuration files. Ensure the changelog
reflects only the actual changes being made in this pull request.
In `@rector.php`:
- Around line 10-11: The `importNames()` method call in the rectorConfig is
using named parameters (importNames: true, importDocBlockNames: false), but this
method only accepts positional arguments. Replace the named parameters with
positional boolean arguments in the correct order for the `importNames()`
method, or alternatively use the modern `withImportNames()` method instead,
which is the recommended approach. Either solution will resolve the parameter
syntax issue.
In `@tests/config/definitions-closure-not-return-type.php`:
- Line 8: The fixture definition for 'closure-not-return-type' currently
includes a return type annotation `: ArrayObject`, but the test
testThrowRuntimeExceptionWhenDefinitionClosureMissingReturnType() expects a
closure without a return type to trigger a RuntimeException. Remove the `:
ArrayObject` return type annotation from the closure in the
'closure-not-return-type' definition, changing it from `static fn(): ArrayObject
=> new ArrayObject()` to `static fn() => new ArrayObject()`, so that the fixture
matches what the test validates.
In `@tests/config/singletons-closure-not-return-type.php`:
- Line 8: Remove the return type annotation (`: ArrayObject`) from the closure
assigned to the `'closure-not-return-type'` key in the fixture. The test
`testThrowRuntimeExceptionWhenSingletonClosureMissingReturnType()` expects
closures without return types to throw a RuntimeException, so the fixture
closure definition must not include the return type declaration to match the
test expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2d3c5182-6e6d-44da-a2d9-3473827eb345
📒 Files selected for processing (5)
CHANGELOG.mdcomposer.jsonrector.phptests/config/definitions-closure-not-return-type.phptests/config/singletons-closure-not-return-type.php
💤 Files with no reviewable changes (1)
- composer.json
📜 Review details
⏰ Context from checks skipped due to timeout. (19)
- GitHub Check: quality / EditorConfig (ubuntu-latest)
- GitHub Check: quality / Prettier (ubuntu-latest)
- GitHub Check: phpunit-compatibility / PHP 8.3-ubuntu-latest
- GitHub Check: phpunit-compatibility / PHP 8.1-windows-2022
- GitHub Check: phpunit-compatibility / PHP 8.4-ubuntu-latest
- GitHub Check: phpunit-compatibility / PHP 8.1-ubuntu-latest
- GitHub Check: phpstan / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit-compatibility / PHP 8.2-windows-2022
- GitHub Check: phpunit / PHP 8.4-windows-2022
- GitHub Check: phpstan-console / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit-compatibility / PHP 8.4-windows-2022
- GitHub Check: phpunit / PHP 8.5-windows-2022
- GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
- GitHub Check: easy-coding-standard / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit / PHP 8.5-ubuntu-latest
- GitHub Check: phpunit / PHP 8.3-ubuntu-latest
- GitHub Check: phpunit / PHP 8.3-windows-2022
- GitHub Check: phpunit-compatibility / PHP 8.1-windows-2022
- GitHub Check: phpunit / PHP 8.5-windows-2022
🔇 Additional comments (1)
CHANGELOG.md (1)
18-18: ⚡ Quick winThe changelog entry is inconsistent with the actual changes.
This entry describes adding return types as a "refactor" with no functional modifications, but the test fixtures
closure-not-return-typeare specifically designed to test ServiceMap's validation when closures lack return types. Adding return types to these fixtures breaks the tests that depend on their absence, making this a functional/breaking change rather than a pure refactor.The entry should either:
- Acknowledge that this is a breaking change requiring test updates, or
- Be revised if the approach changes (e.g., creating new fixtures instead of modifying existing ones)
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Pull Request