Skip to content

Create pie chart#6

Open
KuiMing wants to merge 27 commits into
yihui:masterfrom
KuiMing:master
Open

Create pie chart#6
KuiMing wants to merge 27 commits into
yihui:masterfrom
KuiMing:master

Conversation

@KuiMing

@KuiMing KuiMing commented May 12, 2015

Copy link
Copy Markdown
  1. Create Pie Chart. echart(x,~name, ~value,type='pie')
  2. Data removable and calculable.
  3. MagicType, restore and saveAsImage was added.

Comment thread R/example.R Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like a good example in my eyes. Ideally we should not require users to prepare a huge list for echart(), otherwise that defeats the purpose of this package. Instead, we want something as simple as echart(data, ~variable, type = 'pie'). Do you have a better example?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's my fault. It was just for testing on my own. I will give a simple example.

@yihui

yihui commented May 14, 2015

Copy link
Copy Markdown
Owner

Two more things:

  1. Please provide some screenshots.
  2. Eventually I will need you to clean up the commit history. If you are not very familiar with GIT, I have some instructions here: https://github.com/yihui/knitr/blob/master/CONTRIBUTING.md#pull-requests

Thanks!

1. give a real example code for pie chart.
2. give a pie.html
3. remove unnecessary code of data.R and echart.R
4. add eConfig and etoolbox in option.R
@KuiMing

KuiMing commented May 17, 2015

Copy link
Copy Markdown
Author

Improvement according to comment at 2015/5/14

  1. give a real example code for pie chart.
  2. give a pie.html
  3. remove unnecessary code of data.R and echart.R
  4. add eConfig and etoolbox in option.R

@KuiMing

KuiMing commented May 17, 2015

Copy link
Copy Markdown
Author

One more thing, I will rebase after you confirm these are ok.

@KuiMing

KuiMing commented May 24, 2015

Copy link
Copy Markdown
Author

Hello Yihui,

Did you check my new code? Is there anything I need to modify?

KuiMing added 2 commits June 14, 2015 17:43
1. create candlestick chart
2. modify pie chart
version update
egauge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants