Create pie chart#6
Open
KuiMing wants to merge 27 commits into
Open
Conversation
KuiMing
commented
May 12, 2015
- Create Pie Chart. echart(x,~name, ~value,type='pie')
- Data removable and calculable.
- MagicType, restore and saveAsImage was added.
Owner
There was a problem hiding this comment.
This does not look like a good example in my eyes. Ideally we should not require users to prepare a huge list for echart(), otherwise that defeats the purpose of this package. Instead, we want something as simple as echart(data, ~variable, type = 'pie'). Do you have a better example?
Author
There was a problem hiding this comment.
Sorry, it's my fault. It was just for testing on my own. I will give a simple example.
Owner
|
Two more things:
Thanks! |
1. give a real example code for pie chart. 2. give a pie.html 3. remove unnecessary code of data.R and echart.R 4. add eConfig and etoolbox in option.R
Author
|
Improvement according to comment at 2015/5/14
|
Author
|
One more thing, I will rebase after you confirm these are ok. |
Author
|
Hello Yihui, Did you check my new code? Is there anything I need to modify? |
1. create candlestick chart 2. modify pie chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.