Skip to content

fix: comprehensive cta qa #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlife5 merged 1 commit into from
Jun 18, 2026
Merged

fix: comprehensive cta qa #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/atoms/cta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ export const CTA = (props: CTAProps) => {
}}
>
{linkContent}
{openInNewTab && (
{openInNewTab && ctaType !== "presetImage" && (
<FaExternalLinkAlt
aria-hidden="true"
className="inline-block ml-1 w-3 h-3 align-middle relative -top-px"
Expand Down
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/contentBlocks/ComprehensiveCTA.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ export const ComprehensiveCTA = ({
id={actionType === "button" ? currentValue.data.customId : undefined}
label={effectiveLabel}
link={
actionType === "link" && resolvedCta
actionType === "link" && ctaType !== "getDirections" && resolvedCta
Comment thread
benlife5 marked this conversation as resolved.
? resolveComponentData(resolvedCta.link, locale, streamDocument)
: undefined
}
Expand Down
Loading