Skip to content

fix(test): row-pair leaf layout in merkle_root_parity GPU parity tests #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MauroToscano wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

fix(test): row-pair leaf layout in merkle_root_parity GPU parity tests #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions crypto/math-cuda/tests/merkle_root_parity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ fn gpu_merkle_root(columns: &[Vec<u64>], blowup: usize, weights: &[u64]) -> [u8;
}
}

// Per-row leaves (rows_per_leaf = 1): this parity test compares the generic
// keccak-leaves + Merkle primitives against a per-row CPU reference.
let gpu_leaves = math_cuda::merkle::keccak_leaves_base(&flat, n_lde, num_cols, n_lde, 1)
// Row-pair leaves (rows_per_leaf = 2, matching `ROWS_PER_LEAF`): the CPU
// reference is `commit_rows_bit_reversed`, which hashes bit-reversed row
// pairs into each leaf, so the generic GPU keccak-leaves + Merkle path must
// use the same row-pair layout to produce a matching root.
let gpu_leaves = math_cuda::merkle::keccak_leaves_base(&flat, n_lde, num_cols, n_lde, 2)
.expect("GPU keccak leaves");
let nodes =
math_cuda::merkle::build_merkle_tree_on_device(&gpu_leaves).expect("GPU Merkle tree");
Expand Down Expand Up @@ -191,8 +193,10 @@ fn gpu_ext3_merkle_root(columns: &[Vec<Fp3>], blowup: usize, weights: &[u64]) ->
}
}

// Row-pair leaves (rows_per_leaf = 2, matching `ROWS_PER_LEAF`) to match the
// row-pair `commit_rows_bit_reversed` CPU reference below.
let gpu_leaves =
math_cuda::merkle::keccak_leaves_ext3(&flat_for_keccak, lde_size, num_cols, lde_size, 1)
math_cuda::merkle::keccak_leaves_ext3(&flat_for_keccak, lde_size, num_cols, lde_size, 2)
.expect("GPU ext3 keccak leaves");
let nodes =
math_cuda::merkle::build_merkle_tree_on_device(&gpu_leaves).expect("GPU Merkle tree");
Expand Down
Loading