review(stark): tidy test layout + remove AGENTS.md (follow-up to #740)#744
Merged
MauroToscano merged 1 commit intoJun 29, 2026
Merged
Conversation
Two items that landed too late for #740: - Move the shared make_valid_simple_proof helper out of small_trace_tests.rs into tests/trace_test_helpers.rs, where the crate keeps shared test helpers (matching how prover_tests sources get_trace_evaluations). row_pair_opening_tests.rs and small_trace_tests.rs now both import it from there instead of one test file reaching sideways into another. - Delete AGENTS.md (added by #735).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups that landed after #740 had already merged.
Shared test helper →
trace_test_helpers.rs#740leftrow_pair_opening_tests.rsimportingmake_valid_simple_prooffrom a sibling test file (use super::small_trace_tests::...) — the only file in the suite that reached sideways into another test module. The crate's convention is shared test helpers live intests/trace_test_helpers.rs(e.g.prover_testssourcesget_trace_evaluationsfrom there). This movesmake_valid_simple_proofintotrace_test_helpers.rs; bothsmall_trace_tests.rsandrow_pair_opening_tests.rsnow import it from the shared module. Keeps test code in the#[cfg(test)]tests/tree and out of the production source files.Remove
AGENTS.mdAdded by #735; removed per request.
Verification
cargo test -p stark— 136 passed.make lint— clean across all three combos.