Remove unused batched-LDE wrapper functions#743
Open
MauroToscano wants to merge 1 commit into
Open
Conversation
coset_lde_batch_base_into_with_merkle_tree, coset_lde_batch_ext3_into_with_merkle_tree, and coset_lde_batch_ext3_into_with_leaf_hash have no callers anywhere (only their own definitions + an assert-message string). They are thin non-keep wrappers over the *_inner functions, which stay live via the *_keep variants (the R1 GPU path, called from stark::gpu_lde) and coset_lde_batch_base_into_with_leaf_hash. Pure deletion, -75 lines.
ColoCarletti
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure deletion of dead code — −75 lines, 0 added.
These three
pub fns incrypto/math-cuda/src/lde.rshave no callers anywhere (verified across the whole repo — the only references are their own definitions and anassert_u32_domainmessage string):coset_lde_batch_base_into_with_merkle_treecoset_lde_batch_ext3_into_with_merkle_treecoset_lde_batch_ext3_into_with_leaf_hashThey are thin non-
_keepwrappers that delegate to the*_innerfunctions. Those*_innerfunctions stay alive through their other callers, so nothing is orphaned by this removal:..._base_..._inner— still called bycoset_lde_batch_base_into_with_merkle_tree_keep(the R1 GPU path, called fromstark::gpu_lde) andcoset_lde_batch_base_into_with_leaf_hash...._ext3_..._inner— still called bycoset_lde_batch_ext3_into_with_merkle_tree_keep.This is independent of #715; the functions were already dead on
main(their caller count is unchanged by any open PR).Verification
*_innerhelpers and both*_keepvariants are retained and still referenced.rustfmtclean.math-cudarequires the CUDA toolchain (nonvccon the dev box). This is a pure deletion of verified-uncalled functions with no remaining references, but a CUDA build should confirm before merge.