Address issues with argument parsing for del command and multi commands - #178
Open
cfredhart wants to merge 6 commits into
Open
Address issues with argument parsing for del command and multi commands#178cfredhart wants to merge 6 commits into
cfredhart wants to merge 6 commits into
Conversation
…it test provided in yeahoffline#135.
…ssed as a single array
cfredhart
changed the title
mikkopiu
added a commit
to espoon-voltti/evaka
that referenced
this pull request
May 10, 2021
…-mock - Unfortunately redis-mock currently has an open issue (yeahoffline/redis-mock#135) and an un-merged fix for it (yeahoffline/redis-mock#178) that means it doesn't support multiple arguments (i.e. spread) for the `.del()` method -> to allow using the mock library in tests add support to AsyncRedisClient for using an array of keys instead of argument-per-key and always provide the keys to the underlying redis client as an array instead of using the spread operator
mikkopiu
added a commit
to espoon-voltti/evaka
that referenced
this pull request
May 11, 2021
…-mock - Unfortunately redis-mock currently has an open issue (yeahoffline/redis-mock#135) and an un-merged fix for it (yeahoffline/redis-mock#178) that means it doesn't support multiple arguments (i.e. spread) for the `.del()` method -> to allow using the mock library in tests add support to AsyncRedisClient for using an array of keys instead of argument-per-key and always provide the keys to the underlying redis client as an array instead of using the spread operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedisClient.delso that it properly handles multiple keys for multidel.multi.js's_commandfunction to flatten the argument list if it comes as a single element array whose only element is an array.node-redisappears to handle this scenario.