Skip to content

[Filestore] Move tablet state fields - #6832

Open
szumal wants to merge 3 commits into
mainfrom
users/szumal/move-tablet-state-fields
Open

[Filestore] Move tablet state fields#6832
szumal wants to merge 3 commits into
mainfrom
users/szumal/move-tablet-state-fields

Conversation

@szumal

@szumal szumal commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Notes

This is a refactor suggested in #6670

Comment

#6670 (comment)

@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

  • ⚫ tasks + storage (job skipped)
  • ⚫ blockstore (job skipped)
  • ⚫ disk + manager (job skipped)
  • ⚫ filestore (job skipped)

@szumal
szumal force-pushed the users/szumal/move-tablet-state-fields branch 2 times, most recently from 753edd8 to feff93b Compare August 18, 2026 16:35
@szumal
szumal force-pushed the users/szumal/move-tablet-state-fields branch from feff93b to 6095944 Compare August 18, 2026 16:38
@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

  • ⚫ tasks + storage (job skipped)
  • ⚫ blockstore (job skipped)
  • ⚫ disk + manager (job skipped)
  • ⚫ filestore (job skipped)

@szumal szumal changed the title Users/szumal/move tablet state fields [Filestore] Move tablet state fields Aug 18, 2026
@szumal szumal self-assigned this Aug 18, 2026
@szumal szumal added the filestore Add this label to run only cloud/filestore build and tests on PR label Aug 18, 2026
@szumal
szumal marked this pull request as ready for review August 18, 2026 16:40
@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

  • 🚫 filestore (cancelled or timed out before reporting completion)

qkrorlqr
qkrorlqr reviewed Aug 18, 2026
View reviewed changes
Comment thread cloud/filestore/libs/storage/tablet/tablet_state.h
NProto::TFileSystem FileSystem;
NProto::TFileSystemStats FileSystemStats;
NCloud::NProto::TTabletStorageInfo TabletStorageInfo;
TNodeToSessionCounters NodeToSessionCounters;

@qkrorlqr qkrorlqr Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

among the fields moved to TImpl in this PR this is the only one that should actually be moved

it's ok to keep flags like StartupGcExecuted and CompressNodeRef in TIndexTabletState, in the referenced PR I meant large data structures from which the actual shard state is built

@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4873s): all tests PASSED for commit a297e6d.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4540 4539 0 0 0 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qkrorlqr qkrorlqr qkrorlqr left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@szumal szumal

Labels

filestore Add this label to run only cloud/filestore build and tests on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szumal @qkrorlqr