[CYGWIN][MINGW] Remove DJINTEROP_PUBLIC, enum doesn't export symbols - #192
Conversation
|
Hi @carlo-bramini , thanks for this - I agree with your suggestion that putting How do you feel about also adding a new entry in Please may you also bump up the patch version number in Thank you! |
I think that's a good idea, but unfortunately I never played with workflows at the moment, so I don't know how this works and it could be done, I'm sorry.
I added an extra commit with this change. |
No worries, I can look into this another time. LGTM otherwise, so happy to approve! |
I tried to build libdjinterop with both MinGW and Cygwin, but this error comes out:
In my opinion, this error is correct because an
enumdoes not generate binary symbols, so GCC tells us that the attribute has no effect and the-Werroroption handles it as an error.I could not understand why it has been done here too because PR #142 doesn't write any information about the reasons of this change.
In my opinion, this attribute must be removed from that point.
Perhaps MSVC tolerates it, but a more strict compiler like GCC does not.