Build options for devendored build - #188
Merged
Merged
Conversation
mr-smidge
commented
May 15, 2026
| #include <string> | ||
|
|
||
| #include <date.h> | ||
| #include <date/date.h> |
Contributor
Author
There was a problem hiding this comment.
The main github repo seems to use #include <date.h>, but the vcpkg installation results in a prefix, so #include <date/date.h>. The latter seems better, so I've aligned the bundled code with that.
mr-smidge
commented
May 15, 2026
| date::sys_time<std::chrono::seconds> tp; | ||
| in >> date::parse("%F %T", tp); | ||
| date::sys_seconds tp; | ||
| date::from_stream(in, "%F %T", tp); |
Contributor
Author
There was a problem hiding this comment.
For reasons I haven't been able to work out, the vcpkg version of date.h fails to compile on g++ 14, but changing parse() to from_stream() works fine.
Possibly relevant: https://stackoverflow.com/questions/77509755/dateparse-no-matching-overloaded-function-found
mr-smidge
marked this pull request as ready for review
May 15, 2026 22:26
Contributor
Author
|
I've tested that example applications using libdjinterop via CMake's |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build options for a fully devendored build. libdjinterop previously would always use its bundled copies of date.h and sqlite-modern-cpp, but vcpkg has these in its inventory, so these options offer the ability to use that.
This should make the following vcpkg patches for libdjinterop redundant: microsoft/vcpkg#50062
Hopefully fixes #184 too.