feat(mls/database): add AddMissingInstallations Task variant - #341
Merged
Conversation
Durable TaskRunner intent used by libxmtp's device-sync worker: when a sync-group welcome signals a new installation, one task per eligible group reconciles membership with the inbox's latest identity state, retried with backoff instead of a one-shot inline add (xmtp/libxmtp#3897). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved Additive protobuf schema change that adds a new Task variant and message type. The change is backwards-compatible, introduces no runtime behavior changes to existing code, and the author owns this file. You can customize Macroscope's approvability policy. Learn more. |
Contributor
Author
|
Consumer PR (blocked on this one): xmtp/libxmtp#3897 — verified 🤖 Generated with Claude Code |
tylerhawkes
approved these changes
Jul 24, 2026
insipx
added a commit
to xmtp/libxmtp
that referenced
this pull request
Jul 24, 2026
…ngInstallations xmtp/proto#341 merged (a9b4d561); dev/gen_protos.sh from that rev produces zero diff against the checked-in generated files — only the pin moves.
|
🎉 This PR is included in version 3.94.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
insipx
added a commit
to xmtp/libxmtp
that referenced
this pull request
Jul 24, 2026
…ngInstallations xmtp/proto#341 merged (a9b4d561); dev/gen_protos.sh from that rev produces zero diff against the checked-in generated files — only the pin moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
AddMissingInstallations { bytes group_id }variant (oneof tag 7) toxmtp.mls.database.Task, mirroringProcessPendingSelfRemove.Used by libxmtp's device-sync worker: when a sync-group welcome signals a new installation, the worker enqueues one durable task per eligible group to reconcile membership with the inbox's latest identity state, retried with backoff on the TaskRunner — replacing a one-shot inline add whose failures were silently dropped (root cause of the DeviceSync
sendSyncRequestCI flake).Must merge before xmtp/libxmtp#3897, which currently carries hand-written generated code for this variant and will repin
proto_version+ regen once this lands. Field numbers are wire-pinned by persisted task rows in libxmtp (oneof tag 7,group_idfield 1) — do not renumber.🤖 Generated with Claude Code
Note
Add
AddMissingInstallationstask variant to MLS database task protoAdds a new
AddMissingInstallationsoneof variant (field 7) to theTaskmessage in task.proto. The accompanyingAddMissingInstallationsmessage carries abytes group_idfield identifying the target conversation for reconciling group membership with the latest identity state.Macroscope summarized fe2f9e4.