feat(proto): add KpRotation + KpDeletion task variants + regen xmtp_proto - #3813
feat(proto): add KpRotation + KpDeletion task variants + regen xmtp_proto#3813insipx wants to merge 1 commit into
Conversation
…roto Empty payloads give each recurring singleton a stable data_hash for PullInDeadline targeting. Minimal arms keep xmtp_mls compiling standalone; real handlers land with the KP-consumer implementation. gen/ remains regenerated AHEAD of the upstream proto pin (xmtp/proto#339 carries all three messages); proto_version gets bumped to its merge SHA.
|
Claude finished @insipx's task —— View job PR Review
Review Summary (2026-07-02 17:48 UTC)This PR cleanly adds two new recurring task variants for key-package maintenance. The implementation is minimal and appropriately structured as a proto-only change with placeholder handlers. Key observations: ✅ Proto structure is sound — Empty message definitions ( ✅ Safe dispatch handling — Lines 395-404 in tasks.rs provide appropriate warn-and-delete behavior for these task variants before real handlers land ✅ Follows established patterns — Matches the approach used for No critical issues found. The minimal dispatch arms appropriately prevent crashes while keeping Minor observations:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## insipx/taskrunner-recurrence #3813 +/- ##
================================================================
+ Coverage 84.44% 84.47% +0.03%
================================================================
Files 409 409
Lines 60408 60410 +2
================================================================
+ Hits 51009 51029 +20
+ Misses 9399 9381 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Folded into #3805 — both proto regens now ship in one PR (tags 4, 5, 6 + minimal arms). |
Stacked on #3806 (generic TaskRunner recurrence). Proto-only + minimal arms.
Adds
KpRotation(tag 5) andKpDeletion(tag 6) to thexmtp.mls.database.Taskoneof — two recurring singleton tasks for key-package maintenance. Empty payloads give each a stabledata_hashsoPullInDeadline(tag 4, from #3806) can target them.gen/is regenerated AHEAD of the upstream proto pin: add TaskRunner scheduling protos: PullInDeadline, KpRotation, KpDeletion proto#339 carries all three messages;proto_versiongets bumped to its merge SHA once it lands.xmtp_mlscompiling standalone; the real handlers land in the next PR of the stack.🤖 Generated with Claude Code
Note
Add
KpRotationandKpDeletiontask variants to proto and workerKpRotation(tag 5) andKpDeletion(tag 6) as newoneofvariants to theTaskmessage in xmtp.mls.database.rs, with generated serde implementations.Macroscope summarized 395893d.