compose: Fix two leaks#752
Merged
Merged
Conversation
```
Indirect leak of 12 byte(s) in 1 object(s) allocated from:
#0 0x557432e34af8 in malloc (/__w/flatpak-builder/flatpak-builder/builddir/src/flatpak-builder+0x16baf8) (BuildId: fedaf9746ee75c7de57cf0bb3c5eb79d9c0f8dd8)
#1 0x7f95fd995679 in g_malloc (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x67679) (BuildId: 2426ee6f828a10bf4da963a4c474752c33742359)
#2 0x7f95fd3492c4 in asc_icon_policy_set_policy (/usr/lib/x86_64-linux-gnu/libappstream-compose.so.0+0x232c4) (BuildId: 71a33e272677c786f5751c25b4fda845d03010e2)
#3 0x7f95fd72fac0 in g_type_create_instance (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x42ac0) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#4 0x7f95fd7153e3 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x283e3) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#5 0x7f95fd7169e6 in g_object_new_with_properties (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x299e6) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#6 0x7f95fd7179c0 in g_object_new (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a9c0) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#7 0x7f95fd340ce7 (/usr/lib/x86_64-linux-gnu/libappstream-compose.so.0+0x1ace7) (BuildId: 71a33e272677c786f5751c25b4fda845d03010e2)
#8 0x7f95fd72fac0 in g_type_create_instance (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x42ac0) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#9 0x7f95fd7153e3 (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x283e3) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#10 0x7f95fd7169e6 in g_object_new_with_properties (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x299e6) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#11 0x7f95fd7179c0 in g_object_new (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x2a9c0) (BuildId: 0f9dc57097a22c42f8b9d339c75528f2205b3639)
#12 0x557432ed3611 in builder_appstreamcli_compose /__w/flatpak-builder/flatpak-builder/builddir/../src/builder-manifest.c:2467:13
#13 0x557432ecf859 in builder_manifest_cleanup /__w/flatpak-builder/flatpak-builder/builddir/../src/builder-manifest.c:3138:16
#14 0x557432ebb659 in main /__w/flatpak-builder/flatpak-builder/builddir/../src/builder-main.c:1027:12
#15 0x7f95fcfa4600 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a600) (BuildId: 90ebd03ae9d9f42b23b4eb82fdf70352cf744198)
#16 0x7f95fcfa4717 in __libc_start_main (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a717) (BuildId: 90ebd03ae9d9f42b23b4eb82fdf70352cf744198)
#17 0x557432d8f554 in _start (/__w/flatpak-builder/flatpak-builder/builddir/src/flatpak-builder+0xc6554) (BuildId: fedaf9746ee75c7de57cf0bb3c5eb79d9c0f8dd8)
```
Fixes: ba01b6f ("compose: Implement more flexible icon policy")
```
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x7f14ae4e6f2b in malloc (/lib64/libasan.so.8+0xe6f2b) (BuildId: 25975f766867e9e604dc5a71a8befeaed3301942)
#1 0x7f14aebcaca9 in g_malloc (/lib64/libglib-2.0.so.0+0x47ca9) (BuildId: 7460891e8cbad6f228b9a8d1dfc92d12bb8a8a7d)
#2 0x7f14aebb2c50 in g_hash_table_get_keys_as_array (/lib64/libglib-2.0.so.0+0x2fc50) (BuildId: 7460891e8cbad6f228b9a8d1dfc92d12bb8a8a7d)
#3 0x7f14adeb6f01 in asc_compose_process_task_cb (/lib64/libappstream-compose.so.0+0xff01) (BuildId: 8d28b28bdf1a19157fe943d4c23b8d36289b5b71)
#4 0x7f14aebfdc41 in g_thread_pool_thread_proxy (/lib64/libglib-2.0.so.0+0x7ac41) (BuildId: 7460891e8cbad6f228b9a8d1dfc92d12bb8a8a7d)
#5 0x7f14aebf7751 in g_thread_proxy (/lib64/libglib-2.0.so.0+0x74751) (BuildId: 7460891e8cbad6f228b9a8d1dfc92d12bb8a8a7d)
#6 0x7f14ae428ee5 in asan_thread_start(void*) (/lib64/libasan.so.8+0x28ee5) (BuildId: 25975f766867e9e604dc5a71a8befeaed3301942)
```
bbhtt
changed the title
Owner
|
Nice, thank you! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits.