Skip to content

DRAFT: Lower the log level of some manifest warnings on startup#22

Draft
ximinez wants to merge 61 commits into
developfrom
x-startup-manifest-warnings
Draft

DRAFT: Lower the log level of some manifest warnings on startup#22
ximinez wants to merge 61 commits into
developfrom
x-startup-manifest-warnings

Conversation

@ximinez
Copy link
Copy Markdown
Owner

@ximinez ximinez commented Mar 18, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

This change is Reviewable

@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 3 times, most recently from f1c3ed4 to debbd43 Compare March 25, 2025 16:31
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 3 times, most recently from d3134e7 to 8fb8cd6 Compare April 2, 2025 14:46
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 5 times, most recently from 5055730 to b28f854 Compare April 10, 2025 21:43
@ximinez ximinez added NoCI and removed NoCI labels Apr 11, 2025
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch from b28f854 to c0eee77 Compare April 11, 2025 22:32
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 2 times, most recently from f5f9760 to e24712f Compare April 28, 2025 18:46
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch from e24712f to 4077787 Compare May 7, 2025 19:01
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch from 385c1d0 to 211d592 Compare May 15, 2025 16:10
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch from 211d592 to 635736f Compare July 3, 2025 23:38
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 4 times, most recently from b50a499 to 6f4ede7 Compare July 18, 2025 22:37
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 3 times, most recently from d82bcc4 to d7d8f50 Compare July 24, 2025 22:25
@ximinez ximinez force-pushed the x-startup-manifest-warnings branch 4 times, most recently from eaf0204 to 22be306 Compare August 4, 2025 17:08
* commit '2c1fad1023':
  chore: Apply clang-format width 100 (6387)
…t-warnings

* ximinez/develop:
  ci: [DEPENDABOT] bump actions/upload-artifact from 4.6.2 to 6.0.0 (6396)
  ci: [DEPENDABOT] bump actions/checkout from 4.3.0 to 6.0.2 (6397)
  ci: [DEPENDABOT] bump actions/setup-python from 5.6.0 to 6.2.0 (6395)
  ci: [DEPENDABOT] bump tj-actions/changed-files from 46.0.5 to 47.0.4 (6394)
  ci: [DEPENDABOT] bump codecov/codecov-action from 5.4.3 to 5.5.2 (6398)
  ci: Build docs in PRs and in private repos (6400)
  ci: Add dependabot config (6379)
  Fix tautological assertion (6393)
…t-warnings

* ximinez/develop: (128 commits)
  refactor: Remove unused notTooManyOffers function from NFTokenUtils (6737)
  fix: Change `Tuning::bookOffers` minimum limit to 1 (6812)
  chore: Make pre-commit line ending conversions work on Windows (6832) (6833)
  fix: Add description for `terLOCKED` error (6811)
  fix: Address AI reviewer comments for Permission Delegation (6675)
  refactor: Combine `AMMHelpers` and `AMMUtils` (6733)
  feat: Add MPT support to DEX (5285)
  fix: Handle WSClient write failure when server closes WebSocket (6671)
  ci: Change conditions for uploading artifacts in public/private/org repos (6734)
  refactor: Rename non-functional uses of `ripple(d)` to `xrpl(d)` (6676)
  refactor: Move more helper files into `libxrpl/ledger/helpers` (6731)
  fix: Minor RPC fixes (6730)
  fix: Prevent deletion of MPTokens with active escrow (6635)
  fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback (6646)
  fix: Add assorted Lending Protocol fixes (6678)
  fix: Change variable signedness and correctly handle `std::optional` (6657)
  refactor: Reorganize RPC handler files (6628)
  chore: Update XRPLF/actions (6713)
  docs: Add explanatory comment to checkFee (6631)
  fix: Decouple reserve from fee in delegate payment (6568)
  ...
…t-warnings

* ximinez/develop:
  chore: Update zlib to 1.3.2, sqlite to 3.53.0, libarchive to 3.8.7, jemalloc to 5.3.1, boost to 1.91.0 (7084)
  chore: Update conan.lock (7081)
  chore: Mark empty transactor invariants as future work (7080)
  chore: Update default values of base and owner reserve to 1/0.2 (6382)
  fix: Fix regressions in `server_definitions` (7008)
  chore: Do not duplicate sanitizer flags (7058)
  ci: Run pre-commit on diff in clang-tidy workflow (7078)
  ci: Use XRPLF/create-issue (7076)
  ci: Rewrite clang-tidy workflow(s) in a reusable manner (7062)
  chore: Ignore identifier-naming update in git blame (7066)
  refactor: Enable clang-tidy `readability-identifier-naming` check (6571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant