Use bigint for paths to avoid PathTooLarge errors - #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core lowering and CLVM path codegen for every symbol reference; behavior should match for normal depths but large-path edge cases depend on the new BigUint math and atom encoding.
Overview
CLVM environment paths are now represented with
BigUintend-to-end instead ofu32, so deep binding trees no longer fail withPathTooLarge.Environment::pathbuilds paths with left-shift/add instead ofchecked_mul, andPathError::PathTooLargeis removed (onlySymbolNotFoundremains).Lir::Pathand lowering/codegen/optimizer call sites useBigUint; path atoms go throughpath_to_atomwith the same big-endian trimming behavior, extended for large values.Path math in
path.rs(first_path,rest_path,parent_path) is rewritten for arbitrary size, with a new test that walks 100rest/parentsteps.Reviewed by Cursor Bugbot for commit f88faa3. Bugbot is set up for automated code reviews on this repo. Configure here.