[script.module.buggalo] 1.1.7 - #719
Merged
Merged
Conversation
enen92
reviewed
Dec 23, 2017
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <addon id="script.module.buggalo" name="Buggalo Exception Collector" version="1.1.6" provider-name="twinther"> | |||
| <addon id="script.module.buggalo" name="Buggalo Exception Collector" version="1.1.7" provider-name="twinther"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
enen92
reviewed
Dec 23, 2017
| d = gui.BuggaloDialog(SUBMIT_URL, GMAIL_RECIPIENT, heading, data) | ||
| if not GMAIL_RECIPIENT == None and EMAIL_CONFIG == None: # for backwards-compatibility | ||
| EMAIL_CONFIG = {'recipient':GMAIL_RECIPIENT} | ||
| print SUBMIT_URL |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
SchapplM
added a commit
to SchapplM/script.module.buggalo
that referenced
this pull request
Dec 24, 2017
Author
|
I updated the requested files |
This was referenced Dec 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Following the discussion in #679 (comment), I would like to merge an update to script.module.buggalo. The addon does not seem to be maintained any more. The addon does not seem to be used by more than 3 addons, but it is in my opinion very helpful for more efficient addon development.
As described in my PR twinther/script.module.buggalo#6 and in the new buggalo Readme, for bug report emails to work, login credentials to an email server have to be placed in plain text in the source code of the addons.
Ideally, every developer would create email accounts for his addons and set a different password for the smtp authentification than for account login.
I am not sure how fast these credentials could be used by spambots, if passwords have to be changed often or if this in conflict with rules for addons (e.g. regarding safety).
I did not see any other way though to create the email notification, which is very helpful in the early phase of addon development.