Skip to content

[script.module.buggalo] 1.1.7 - #719

Merged
MartijnKaijser merged 2 commits into
xbmc:gothamfrom
SchapplM:gotham_buggalo
Dec 24, 2017
Merged

[script.module.buggalo] 1.1.7#719
MartijnKaijser merged 2 commits into
xbmc:gothamfrom
SchapplM:gotham_buggalo

Conversation

@SchapplM

@SchapplM SchapplM commented Dec 23, 2017

Copy link
Copy Markdown

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Following the discussion in #679 (comment), I would like to merge an update to script.module.buggalo. The addon does not seem to be maintained any more. The addon does not seem to be used by more than 3 addons, but it is in my opinion very helpful for more efficient addon development.

As described in my PR twinther/script.module.buggalo#6 and in the new buggalo Readme, for bug report emails to work, login credentials to an email server have to be placed in plain text in the source code of the addons.
Ideally, every developer would create email accounts for his addons and set a different password for the smtp authentification than for account login.

I am not sure how fast these credentials could be used by spambots, if passwords have to be changed often or if this in conflict with rules for addons (e.g. regarding safety).
I did not see any other way though to create the email notification, which is very helpful in the early phase of addon development.

Comment thread script.module.buggalo/addon.xml Outdated
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="script.module.buggalo" name="Buggalo Exception Collector" version="1.1.6" provider-name="twinther">
<addon id="script.module.buggalo" name="Buggalo Exception Collector" version="1.1.7" provider-name="twinther">

This comment was marked as spam.

Comment thread script.module.buggalo/lib/buggalo.py Outdated
d = gui.BuggaloDialog(SUBMIT_URL, GMAIL_RECIPIENT, heading, data)
if not GMAIL_RECIPIENT == None and EMAIL_CONFIG == None: # for backwards-compatibility
EMAIL_CONFIG = {'recipient':GMAIL_RECIPIENT}
print SUBMIT_URL

This comment was marked as spam.

@enen92 enen92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

SchapplM added a commit to SchapplM/script.module.buggalo that referenced this pull request Dec 24, 2017
@SchapplM

Copy link
Copy Markdown
Author

I updated the requested files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants