[service.subtitles.napiprojekt] 3.0.0 - #2889
Conversation
|
| Filename | Overview |
|---|---|
| service.subtitles.napiprojekt/resources/lib/addon.py | Implements Kodi request dispatch and video hashing, but its timeout leaves a slow VFS worker running after the search reports failure. |
| service.subtitles.napiprojekt/resources/lib/napiprojekt.py | Implements API access, throttling, response decoding, and subtitle persistence; valid date-form Retry-After values are ignored and shared throttle state is race-prone. |
| service.subtitles.napiprojekt/service.py | Provides a minimal Kodi entry point that imports and executes the add-on request handler. |
| service.subtitles.napiprojekt/addon.xml | Updates add-on metadata, Python dependency, subtitle entry point, licensing, language, and artwork declarations. |
Reviews (1): Last reviewed commit: "[service.subtitles.napiprojekt] 3.0.0" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| with urlopen(request, timeout=REQUEST_TIMEOUT) as response: | ||
| return response.read() | ||
| except HTTPError as exc: | ||
| if exc.code == 429: | ||
| try: | ||
| retry_after = float( | ||
| exc.headers.get("Retry-After", RATE_LIMIT_FALLBACK) |
There was a problem hiding this comment.
When NapiProjekt returns HTTP 429 with a valid HTTP-date in Retry-After, float() rejects it and substitutes the ten-second fallback, causing requests to resume before the server's requested cooldown and potentially repeat the rate-limit failure.
| @classmethod | ||
| def _throttle(cls): | ||
| wait_seconds = cls._read_next_request_time() - time.time() | ||
| if wait_seconds > 0: | ||
| log("Waiting %.1f seconds before the next API request" % wait_seconds) | ||
| xbmc.sleep(int(wait_seconds * 1000) + 1) | ||
|
|
||
| # Reserve the next slot before opening the connection. This also | ||
| # limits a download launched by a separate Kodi plugin invocation. | ||
| cls._write_next_request_time(time.time() + API_MIN_INTERVAL) |
There was a problem hiding this comment.
If separate add-on invocations overlap, both can read and reserve the same timestamp or overwrite a longer 429 cooldown, defeating the cross-invocation interval and producing avoidable rate-limit failures.
| it.daemon = True | ||
| it.start() | ||
| it.join(timeout_duration) | ||
| if it.is_alive(): | ||
| return it.result | ||
| else: | ||
| return it.result |
There was a problem hiding this comment.
When a network-backed video read exceeds fifteen seconds, timeout() returns without cancelling or joining the worker, so Kodi reports a hash failure while the abandoned thread continues reading and retaining its VFS resource.
1 participant
Description
This update restores the functionality of the NapiProjekt subtitle add-on for modern Kodi versions and the current NapiProjekt API.
Main changes
Retry-Afterhandling;.srt);[start][end](.sub);{start}{end}(.sub);Checklist:
Additional information :