[script.module.pyrollbar@matrix] 1.4.0 - #2861
Conversation
|
@kodiai review |
Kodiai Add-on ReviewSummaryReviewed 1 changed addon on Findings
VerdictNeeds human review: 18 errors and 3 warnings found. Final approval remains with a human reviewer. |
|
@romanvm It turns out that rollbar 1.4.0 requires python 3.10+ and therefore does not work with any of the windows kodi packages. Rollbar 1.3.0 will work Would releasing 1.3.0 under a version number like "2026.08.08+1.3.0" to force a rollback be an acceptable solution, or is there another rollback option? Alternatively I could remove the rollbar dependency from my addon, but some old addons use it as well (which are presumably broken now): |
|
That is unfortunate, considering that the submission has been pushed into "matrix" branch that is supposed to be compatible with the older Kodi version, starting from Matrix. Direct downgrading is not an option because Kodi uses so called lexicographic comparison for comparing version numbers. In short, it compares ASCII codes of the respective characters, so "1.2" is considered higher than "1.1" and "1". Yes, technically "2026.08.08+1.3.0" will be higher than "1.4.0", but I'm thinking for consistent version numbering for the future versions. If a person who will maintain this library in the Kodi repo will be able to maitain the consistent version numbering with the new schema then I see no problem with that. |
|
Sadly it looks like the addon checker will not accept this format:
Any recommendations? |
|
Sorry for a late reply. Claude code suggests "1.4.0.1+v1_3_0" version that should pass validation and will be considered higher than "1.4.0" to trigger an update. Try this variant. And include an explanation somewhere in the changelog. |
|
Though it gets through the addoncheck, it doesn't get through create_repository.py. I'm using the chad_parry script. I can work around it for my repo, but I'm worried about breaking the official repo if I submit it. Do you know if it uses the same script? |
|
I have no idea what that script does but you can always create a pull request with addon submission manually. You don't need a script for that. As the last resort I can bypass the addon checker and merge the PR after review. |
|
I went ahead and opened a PR here |
Add-on details:
General
Code location
Python notifier for reporting exceptions, errors, and log messages to Rollbar.
Description of changes:
Update Rollbar API to 1.4.0
Checklist: