Fix: GRID multi-select screens (Augmenter event) cause infinite loop#27
Merged
Merged
Conversation
…n\nProblem: Events like Augmenter use GRID screens with for_transform=False \nand num_cards=2. The existing CommonTransformHandler only handles \nfor_transform=True, causing DefaultChooseHandler to get stuck in an \ninfinite loop selecting/deselecting the first card.\n\nSolution: Added CommonGridSelectHandler that handles any GRID screen \nwith num_cards > 0, properly tracks selected_cards count, and sends \nconfirm when all cards are selected.\n\nIncludes tests based on actual game log data from the Augmenter event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Events like Augmenter use GRID screens with for_transform=False and num_cards=2. The existing CommonTransformHandler only handles for_transform=True, causing DefaultChooseHandler to get stuck in an infinite loop selecting/deselecting the first card.
Solution: Added CommonGridSelectHandler that handles any GRID screen with num_cards > 0, properly tracks selected_cards count, and sends confirm when all cards are selected. Includes tests based on actual game log data from the Augmenter event.