Fix precision loss on large integers and bigint#833
Open
kvch wants to merge 1 commit into
Open
Conversation
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve int64 precision on the WAL and snapshots.
Related Issue(s)
Type of Change
Please select the relevant option(s):
Changes Made
A single primitive applied at both decode sites.
internal/json.UnmarshalUseInt64: sonic configured withUseInt64: true. Integer JSON numbers decode toint64(full int64 range); non-integer numbers still decode tofloat64.pkg/wal/listener/postgres.Listenernow usesUnmarshalUseInt64on the wal2json payload.internal/postgres.registerTypesToConnMapoverrides pgx's defaultJSONCodecandJSONBCodecwith versions whoseUnmarshalfield isinternal/json.UnmarshalUseInt64. This is set on every pgx connection (viapgxpool.Config.AfterConnect/Connsetup), so it covers every place pgx scans a json/jsonb value intoanypostgres_wal_dml_adapter.go/_bulk.gonow acceptint64(andint/int32) in addition tofloat64for sequence columns via a smalltoInt64helper, since values coming out of the new decoder areint64.The internal-
json.Unmarshalcallers elsewhere in the codebase are unchanged.Testing
Checklist