feat: support environment variables in YAML configuration#790
Merged
Conversation
Expand ${VAR} references in YAML config files using os.ExpandEnv
before parsing. This avoids exposing secrets in config files.
Applied to all three YAML parsing paths: LoadFile (viper),
ParseStreamConfig (yaml.Unmarshal), and ParseTransformerConfig.
Fixes xataio#383
kvch
requested changes
Jun 3, 2026
Collaborator
kvch
left a comment
kvch
left a comment
There was a problem hiding this comment.
This is a great feature! However, the implementation breaks the transformer configurations. Could you please fix the code so it only expands ${...} variables?
os.ExpandEnv also expanded bare $VAR forms, which broke transformer configurations containing template/regex dollar syntax ($1, $name, $$). Replace it with a braced-form-only expander and cover the passthrough cases with table tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Fixed - expansion now only touches ${...} forms (valid env identifier inside braces). Bare $VAR and transformer template/regex dollar syntax ( |
kvch
approved these changes
Jun 4, 2026
Collaborator
|
Thank you for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
os.ExpandEnvsupport to YAML config parsing so users can reference environment variables like${DB_PASSWORD}in config files instead of hardcoding secrets.Applied to all three YAML-backed parsing paths:
LoadFile(viper): reads file manually, expands env vars, feeds toviper.ReadConfigParseStreamConfig(yaml.Unmarshal): expands before the case-sensitive YAML parseParseTransformerConfig: expands before transformation rule parsingAlso handles the transformer rules merge path (
PGSTREAM_TRANSFORMER_RULES_FILE).Example config:
Fixes #383
This contribution was developed with AI assistance (Codex).