Show Dragon Survival head and neck in first person - #234
Closed
rsdadada wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds minimal compatibility for Dragon Survival by keeping the dragon head and neck visible while RealCamera is active.
The fix applies to:
Root cause
Dragon Survival intentionally hides the dragon head and neck in normal first-person rendering through its
Compat.displayNeck()method.Because the geometry is not submitted by Dragon Survival, RealCamera cannot capture or render the missing head model by itself.
The latest Dragon Survival 26.1 code otherwise works correctly with RealCamera, so no model ownership changes, GeckoLib-specific rendering hooks, or texture filtering are required.
Implementation
This PR adds an optional
@Pseudomixin targeting:It modifies the return value of
displayNeck()so that the original result is preserved, while also displaying the head and neck when:The mixin uses
require = 0, so RealCamera can still load normally when Dragon Survival is not installed or when the target method is unavailable.Scope
This change intentionally does not add:
These systems are unnecessary for the current Dragon Survival 26.1 implementation.
Validation
The following cases should be checked: