Add Dragon Survival compatibility - #233
Closed
rsdadada wants to merge 2 commits into
Closed
Conversation
Collaborator
|
没有任何必要这么做,你为什么要这么做 |
Collaborator
额,复制markdown查看吧,我也不知道为什么代码会到最后 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderInFirstPersonoption is enabled.Root cause
RealCamera and Dragon Survival could both submit a first-person body, producing two incomplete models and a view-dependent floating model. Handing body ownership to Dragon Survival removes that duplicate, but also means RealCamera's normal captured-model filtering no longer sees Dragon Survival's GeckoLib geometry.
The disable editor and the world render may receive the same dragon geometry under different texture owners. The simplified world filter also submitted a quad after the first depth-eligible, non-matching vertex, so a disabled UV on any later vertex was missed. Together these caused layer-specific disable records to be discarded and made a face sometimes remain visible in the world.
Implementation
DragonStateProvider.isDragonand the liveClientDragonRenderer.renderInFirstPersonvalue. Reflection failures warn once and fail open to RealCamera's original behavior.RoutingSubmitCollector, including ordered submissions.@Pseudomixin to preserve dragon head/neck rendering while RealCamera or its model view is active.Validation
./gradlew.bat clean build --no-daemon --console=plain(Common, Fabric, and NeoForge all passed).6217368. There is no official published Dragon Survival file for Minecraft 26.1.x.268e5f0, which targets Minecraft 26.1, was compile-checked for the older instance but was not runtime-validated.This remains a draft pending one final in-game regression pass of the updated per-layer world filter.