Support independent rotation axis binding - #232
Closed
rsdadada wants to merge 1 commit into
Closed
Conversation
rsdadada
marked this pull request as ready for review
July 10, 2026 13:59
rsdadada
force-pushed
the
codex/independent-rotation-axis-binding
branch
from
July 10, 2026 14:05
4e16197 to
a2766d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
As discussed in #17, one rotation matrix can have multiple equivalent Euler representations. That ambiguity is harmless while applying all three components, but it becomes visible when components are selected independently.
This PR defines an explicit policy for partial binding: evaluate both equivalent Y-X-Z branches, unwrap them against the previous frame, and choose the nearest branch. At ±90° pitch, the previous frame fixes the otherwise unobservable yaw/roll split. After a lifecycle reset, vanilla camera orientation is used as the initial reference.
This implements the independent-axis alternative mentioned in #64. It does not claim to recover separate head and body transforms from one flattened model matrix.
Compatibility
000: returns vanilla pitch/yaw/roll exactly111: returns the previous principal Euler extraction exactlybindRotationmaps to all three new flagspitch && yaw && rollBindConfigconstructor andbindRotation()accessor remain availableThe public record now has six components, so consumers reflecting over record components will observe the expanded shape.
Validation
.\gradlew.bat clean build --no-daemonRelated to #17 and #64.