feat: every column a style declares, in the editor - #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The style editor now holds every column a style declares, not the ten the parser happened to read.
StyleFormatreads all twenty-three by name,AssStylerecords where each sits, and the dialog draws them in the groups the reference's own dialog uses: font, colours, margins, outline, alignment, miscellaneous.Two of them are not text boxes, because they are not text. The alignment is the grid: nine buttons, and ASS counts from the bottom left, so the top row is 7, 8, 9 and the number a place writes is not its position on screen. The opaque box is drawn as what it is, a border style writing 3 or 1, rather than as a fifth flag beside bold and italic.
Two names are worth stating because the format reuses them.
Outlineis the border's width andShadowis the shadow's depth;OutlineColourandBackColourare the colours the dialog labels Outline colour and Shadow colour. They are different columns and the record keeps them apart asoutline_widthandshadowagainstoutlineandback.The harness needed one change: the panel is taller than the window now and scrolls inside itself, so a control further down had a rectangle outside the viewport and a click at its centre landed on nothing. The spec brings the element into view before it measures.
Changes
Format:line.AssStyle, andass_style_texthanding back nineteen readable values instead of seven.AssStyleFieldvariants and the span each names.How to verify it by using the app
fixtures/subtitles/ass/clean/basic.assand click Edit beside the Style dropdown.Dialogue:line is exactly the bytes it was.Verified on Linux: full gate green step by step, and the battery green at 36 spec files of 36 with 296 checks. One mutation, the alignment column read at the encoding's index, reddened the grid check first.