Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Row three's font button, which is the last control of that row Sublore did not have. It sits with the four style flags and not with the colours, because that is where the reference's own sizer puts it, and it opens a picker holding the families installed on this machine, a field to type one into, and a size. Choosing writes
\fnand\fsas one step.The enumeration behind it is new and it asks nothing of a toolkit or a subprocess. WebKitGTK implements no way for the page to list local fonts,
fc-listis a command a minimal system need not have installed even where the library is, and a crate would be a dependency for one table, sosrc-tauri/src/fonts.rswalks the directories a font is installed into and reads thenametable out of each file. It found 290 families here. Everything in it treats the file as hostile, because a font is a binary somebody else wrote: every read is bounds-checked, a malformed file costs that file and nothing else, and the walk is capped in depth, in files opened and in bytes read.Writing two tags as one step needed a planner,
Edit::SetOverrideTags, which BACKLOG N39 said both the font and the colour's alpha wanted. One thing was tried inside it and taken back out: moving the caret by each write's shift. No line could be found where it changed the result, becauseset_tagwrites where the caret is and the block it just made is what the next write finds there. Keeping it would have been dead code, and the comment where it stood says what was tried.Changes
nametable of every font file, with the walk capped and eight tests including a sweep over every prefix of a real font.subtitle_set_override_tags, several tags at one caret.Edit::SetOverrideTagsandplan_set_override_tags, with the name and value check now shared with the single-tag write.setOverrideTags.How to verify it by using the app
fixtures/subtitles/ass/clean/speakers.assand click a row. After B I U S there is an F, greyed, because there is no caret to write at yet.{\fnYour Font\fs48}, and the video shows it drawn that way.Verified on Linux: full gate green step by step, and the battery green at 35 spec files of 35 with 292 checks. One mutation, a planner that writes only the first tag of the list, reddened this check and only this one. A second mutation, moving the caret by each write's shift, reddened nothing at all, and that is why the shift is not in the code.